[Clamav-devel] Code style with commit ffa31264a657618a0e40c51c01e4bfc32e244d13

Shawn Webb lattera at gmail.com
Thu Jul 20 14:36:44 EDT 2017


Hey ClamAV Developers,

The part of the diff that reads:

if ( !(len = sys->read(fh, &buf[0], 256) > 0)) {

is a little awkward. I'm wondering if it would be better to be split
out. Something like this:

len = sys->read(fh, buf, sizeof(buf));
if (len <= 0) {
...
}

That would make the code a bit more readable for future developers. It
would also prevent issues in case the size of buf were to ever change in
the future.

Thanks,

-- 
Shawn Webb
Cofounder and Security Engineer of HardenedBSD

GPG Key ID:          0x6A84658F52456EEE
GPG Key Fingerprint: 2ABA B6BD EF6A F486 BE89  3D9E 6A84 658F 5245 6EEE

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.clamav.net/pipermail/clamav-devel/attachments/20170720/272ae100/attachment.bin>


More information about the clamav-devel mailing list