[Clamav-devel] [PATCH 1/1] Only bring in <execinfo.h> if it's available

Shawn Webb swebb at sourcefire.com
Mon Nov 3 14:21:28 EST 2014


On Mon, Nov 3, 2014 at 2:09 PM, Bernd Kuhls <bernd.kuhls at t-online.de> wrote:

> Hi,
>
> Shawn Webb <swebb at sourcefire.com> wrote in news:CAO2uJaf5EB5O7=5P_
> 6TAp6bs_LOB87t_-XpFfZGuxJy4tE084g at mail.gmail.com:
>
> > Thanks for this patch. Can you please file a bug in our bug tracker at
> > https://bugzilla.clamav.net/?
>
> https://bugzilla.clamav.net/show_bug.cgi?id=11170
> Could you please make this bug report public so the buildroot maintainers
> can
> check it while reviewing my patch?
>
> > Also, instead of modifying configure (which
> > is generated using GNU autotools), can you modify configure.ac instead?
>
> I oriented myself at this commit
>
> https://github.com/vrtadmin/clamav-
> devel/commit/0f9ce68529b9ebf4011cb9a19ac1210eb3f7d317
>
> where I was surprised to see a generated ./configure being part of the git
> repo.
>
> > That way your changes will stick whenever we run autoreconf. The way your
> > patch stands right now is that your changes to the configure script would
> > get wiped away whenever anyone runs autoreconf.
>
> This won´t happen because I patched m4/reorganization/headers.m4 ;)


Gotcha. Sorry, I had missed that part of the patch. Thanks!



More information about the clamav-devel mailing list