[clamav-users] PATCH[2]: Re: ClamAV® blog: ClamAV 0.104.0 Release Candidate is here!

[Mark Fortescue]

Hi Micah,

Having picked up on one set of unset substitution variables I cheated 
and used 'find'. 'grep'. 'sed'. 'cut' and 'sort -u' to go through and 
find all the substitution variables and check that they were set :).

Please note that the CLAMAV_USER changes or setting CLAMAVUSER in the 
documentation are also needed for 0.103.x.

Regards
	Mark.

On 05/08/2021 03:07, Micah Snyder (micasnyd) wrote:
> Thanks for patch #2.  Very good eye catching the CLAMAV_USER and CONFDIR 
> variable issues.
> I've updated the PR with the change: 
> https://github.com/Cisco-Talos/clamav/pull/231
> <https://github.com/Cisco-Talos/clamav/pull/231>
> 	
> CMake: Fix build on systems lacking inttypes format string macros by 
> micahsnyder · Pull Request #231 · Cisco-Talos/clamav 
> <https://github.com/Cisco-Talos/clamav/pull/231>
> Define _SF64_PREFIX and _SF32_PREFIX on systems that do not have these 
> macros: PRIu64, PRIx64, PRIi64, PRIu32, PRIi32, PRIx32 This logic is the 
> same as in the previous build system, here: https://g...
> github.com
> 
> If you see any problems please let me know. Else, if all goes well with 
> testing on my side I'll merge it.
> 
> 
> Micah Snyder
> ClamAV Development
> Talos
> Cisco Systems, Inc.
> ------------------------------------------------------------------------
> *From:* Mark Fortescue <mark.lists at thurning-instruments.co.uk>
> *Sent:* Friday, July 30, 2021 6:36 AM
> *To:* Micah Snyder (micasnyd) <micasnyd at cisco.com>; ClamAV users ML 
> <clamav-users at lists.clamav.net>
> *Subject:* PATCH[2]: Re: ClamAV® blog: ClamAV 0.104.0 Release Candidate 
> is here!
> Hi Micah,
> 
> Please find attached patch #2 to clean up patch #1 'if' statements and
> fix some other issues fond (mostly documentation).
> 
> The outstanding variable is LIBCLAMAV_LIBS.
> 
> It is used by clamav-config.in and libclamav.pc.in.
> 
> Not sure about the logic required for this one. On my OS, it is set to
> '-lbz2' for autotools but I don't know why it is being set and no other
> dependent libraries are there.
> 
> I would expect it to be a list of all dependent libraries used when
> linking with libclamav.
> 
> Regards
>          Mark.
> 
> On 29/07/2021 00:54, Micah Snyder (micasnyd) wrote:
>> How's this? https://github.com/Cisco-Talos/clamav/pull/231
>> 
> 
> <snipped>
>